I feel obligated to contribute to this thread being that I'm a Packers fan and always a Brett Favre fan.
I have to admit Favre definitley is one of those guys who has been around so long that he will eventually set records so it isn't as impressive as someone who does well early in there career, but you have to give him his props.
He does throw a lot of picks and as you pointed out is the all time pick leader, but he has also thrown the most td's, most passing yards, and career pass completions. And yes, I did wikipedia that.
The thing I loved about Favre though was that he was very exciting and didn't care about being making mistakes which made for greater moments and plays than Tom Brady can ever imagine.